FIX: create _dashSeq and _dashOfset before use #5852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
added a commit
that referenced
this pull request
Jan 17, 2016
FIX: create _dashSeq and _dashOfset before use
jenshnielsen
added a commit
that referenced
this pull request
Jan 17, 2016
FIX: create _dashSeq and _dashOfset before use
jenshnielsen
added a commit
that referenced
this pull request
Jan 17, 2016
FIX: create _dashSeq and _dashOfset before use
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
May 22, 2016
FIX: create _dashSeq and _dashOfset before use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5850
This will need to be back-ported to 1.5.x.
I did it this way because on the 2.x branch we add
_dashOffsetwhich is not on 1.5.x and backporting (and dealing with the conflict then) is more reliable that remembering to fix up the second one when merging up).