Skip to content

Fix gridspec.Gridspec: check ratios for consistency with rows and columns #5892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 24, 2016
Merged

Fix gridspec.Gridspec: check ratios for consistency with rows and columns #5892

merged 3 commits into from
Jan 24, 2016

Conversation

julianvmodesto
Copy link
Contributor

@QuLogic QuLogic added this to the proposed next point release (2.1) milestone Jan 21, 2016
tacaswell
tacaswell reviewed Jan 23, 2016
View reviewed changes
lib/matplotlib/tests/test_gridspec.py
Addresses issue #5835.
See at https://github.com/matplotlib/matplotlib/issues/5835.
"""
assert_raises(ValueError, gridspec.GridSpec,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a second one of these which fails via the other path (if I am reading this right this only really tests the width based failure).

@tacaswell
Copy link
Member

Good to see other new yorkers around 😄

@julianvmodesto
Copy link
Contributor Author

Hey there! 😄 🗽 I'll add one. I might reopen a new pull request since I put this on my master branch, and maybe I could fork from the 2.x branch to match the milestone.

@tacaswell
Copy link
Member

Don't worry about that, we are pretty good at back porting

On Sat, Jan 23, 2016, 16:41 Julian V. Modesto notifications@github.com
wrote:

Hey there! [image: 😄] [image: 🗽] I'll add one. I
might reopen a new pull request since I put this on my master branch, and
maybe I could fork from the 2.x branch to match the milestone.

—
Reply to this email directly or view it on GitHub
#5892 (comment)
.

@jenshnielsen jenshnielsen modified the milestones: next major release (2.0), proposed next point release (2.1) Jan 24, 2016
jenshnielsen added a commit that referenced this pull request Jan 24, 2016
@jenshnielsen
Merge pull request #5892 from julianvmodesto/master
30db3ac 
Fix gridspec.Gridspec: check ratios for consistency with rows and columns
@jenshnielsen jenshnielsen merged commit 30db3ac into matplotlib:master Jan 24, 2016
@jenshnielsen jenshnielsen mentioned this pull request Jan 24, 2016
Closed
jenshnielsen added a commit that referenced this pull request Jan 24, 2016
@jenshnielsen
Merge pull request #5892 from julianvmodesto/master
308ce5d 
Fix gridspec.Gridspec: check ratios for consistency with rows and columns
@jenshnielsen
Copy link
Member

Backported to 2.x as 308ce5d

@jenshnielsen
Copy link
Member

Thanks for the fix much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@julianvmodesto @tacaswell @jenshnielsen @mdboom @QuLogic