Skip to content

Doc update donation #5973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 30, 2016
Merged

Conversation

tacaswell
Copy link
Member

Should probably track down if the image changes were intentional or not.

@tacaswell tacaswell added this to the 1.5.2 (Critical bug fix release) milestone Feb 8, 2016
@tacaswell
Copy link
Member Author

These changes are already reflected on the live site.

@jenshnielsen
Copy link
Member

I don't understand why we are still storing these images in the repository. I think they are meant as fall back if Basemap / latex is not installed but they are not actually used anywhere that I can see. I.e. http://matplotlib.org/devdocs/users/screenshots.html#basemap-demo is missing the basemap demo because we don't install basemap on Travis. The make.py file in that directory also doesn't work with modern IPython. There is also a bunch of tex_unicode files which seems to be from a now deleted example. I would suggest getting rid of them all and either get rid of the basemap example (it's already documented in external packages) or make basemap a hard dependency on the docs build.

@tacaswell tacaswell force-pushed the doc_update_donation branch from a383cbf to 80a8e53 Compare March 7, 2016 00:31
@jenshnielsen jenshnielsen merged commit bf82d92 into matplotlib:v1.5.1-doc Mar 30, 2016
@tacaswell tacaswell deleted the doc_update_donation branch May 12, 2016 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants