Skip to content

ENH: add kwarg normalization function to cbook #5975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2016

Conversation

tacaswell
Copy link
Member

This is the first step to centralizing the normalizing kwarg
handling.

This is the first step to centralizing the normalizing kwarg
handling.
@tacaswell tacaswell added this to the 1.5.2 (Critical bug fix release) milestone Feb 8, 2016
@tacaswell
Copy link
Member Author

This is pulled out of #5056 (it is the first commit on that PR) and should be merged first so that we can backport this to 1.5.x (or at least 2.0) as it will help with issues like #5974

@WeatherGod
Copy link
Member

Do we want to try applying it to the existing normalization/validation logic for cyclers? Would be interesting to see how we can apply it fo the needed key-changing feature for existing cycler objects.

@tacaswell
Copy link
Member Author

Probably, but I would rather get this in and then start to use it in later PRs rather than holding this up.

mdboom added a commit that referenced this pull request Feb 15, 2016
ENH: add kwarg normalization function to cbook
@mdboom mdboom merged commit 14294c9 into matplotlib:master Feb 15, 2016
@tacaswell tacaswell deleted the enh_kwarg_normalize branch February 15, 2016 21:26
mdboom added a commit that referenced this pull request Feb 15, 2016
ENH: add kwarg normalization function to cbook
@mdboom
Copy link
Member

mdboom commented Feb 15, 2016

Cherry-picked to 1.5.x as b17cc2c

@efiring
Copy link
Member

efiring commented Feb 16, 2016

This is failing on 2.6:

 File "/home/travis/build/matplotlib/matplotlib/venv/lib/python2.6/site-packages/matplotlib-1.5.1+48.gc6c43cc-py2.6-linux-x86_64.egg/matplotlib/cbook.py", line 2635, in normalize_kwargs

    "are not in kwargs".format(fail_keys))

ValueError: zero length field name in format

@tacaswell
Copy link
Member Author

See #6007

tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull request May 22, 2016
ENH: add kwarg normalization function to cbook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants