Remove fixed colours from xkcd style. #5989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mdboom - any thoughts on this? |
|
shouldn't this be redone to use an xkcd style sheet? |
|
@WeatherGod Can you create an issue for that? That seems like a fun hack-a-thon project. |
tacaswell
added a commit
that referenced
this pull request
Feb 12, 2016
Remove fixed colours from xkcd style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the intent there was to limit the number of colours, but looking at something like https://xkcd.com/657/ I think the Category10 colours are quite fine.
At the moment, using the short names is causing an inconsistency between lines and patches in the example.