Skip to content

Apply new default colours in more places #5995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2016

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Feb 14, 2016

Some hardcoded defaults in scatter, pie, and stemplot (though now that I think about it, maybe that last one should be in rcParams, too.)

Also, set default colour for lines and boxplots to the new blue (and red, in some cases).

Fixes #5990.

@QuLogic QuLogic added this to the 2.0 (style change major release) milestone Feb 14, 2016
@QuLogic
Copy link
Member Author

QuLogic commented Feb 14, 2016

Not sure why CI failed the first time, but I re-started it and it seems to be good now.

@tacaswell
Copy link
Member

I this addresses the same issue as #5674 I believe.

@QuLogic
Copy link
Member Author

QuLogic commented Feb 14, 2016

Hmm, you're probably right, except that one is a bit more general and adds an additional feature for users, while this one is just straight hard-coding. Probably depends on what the consensus is for that new feature.

@@ -827,7 +827,7 @@ def validate_hist_bins(s):
# line props
'lines.linewidth': [2.5, validate_float], # line width in points
'lines.linestyle': ['-', six.text_type], # solid line
'lines.color': ['b', validate_color], # blue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should change to C0?

@tacaswell
Copy link
Member

I think this can be re-worked to use the new 'CN' color specification method?

@QuLogic
Copy link
Member Author

QuLogic commented May 2, 2016

Quite likely; I think a bunch of it is already implemented, too. For the stem plots, the baseline was originally red. That's C2 for the classic colour cycle, but C3 for the new one (C2 is green).

Should I go with C2 everywhere, or just special case classic style with C3 everywhere?

@WeatherGod
Copy link
Member

I think the red of stem plots should be treated specially, as in a separate
argument. I think when most people are thinking of specifying the color of
their stem plots, they are intending to effect only the stems themselves,
and so that should be what is impacted by the colorcycle and default color.

On Sun, May 1, 2016 at 11:28 PM, Elliott Sales de Andrade <
notifications@github.com> wrote:

Quite likely; I think a bunch of it is already implemented, too. For the
stem plots, the baseline was originally red. That's C2 for the classic
colour cycle, but C3 for the new one (C2 is green).

Should I go with C2 everywhere, or just special case classic style with C3
everywhere?


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#5995 (comment)

@QuLogic
Copy link
Member Author

QuLogic commented May 7, 2016

Yes, there is a separate argument for the stem baseline styling; I'm only referring to the default case if nothing's specified.

@QuLogic QuLogic force-pushed the more-default-colours branch 2 times, most recently from 41993b2 to 301bf04 Compare May 14, 2016 02:19
@QuLogic QuLogic force-pushed the more-default-colours branch from 301bf04 to 76756ac Compare May 14, 2016 02:24
@QuLogic
Copy link
Member Author

QuLogic commented May 14, 2016

Rebased to fix latest v2.x build issues.

linemarker = 'None'
linestyle = '-'
else:
linestyle, linemarker, linecolor = \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the \ really needed?

(linestyle, linemarker,
 linecolor) =  _process_plot_format(linefmt)

is another way to break this up

@tacaswell
Copy link
Member

This is down to just stem right?

All of my comments on this are non-critical.

@jenshnielsen jenshnielsen merged commit 8428821 into matplotlib:v2.x May 23, 2016
@QuLogic QuLogic deleted the more-default-colours branch May 23, 2016 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants