Skip to content

Patch for issue #6009 #6014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 6, 2016
Merged

Patch for issue #6009 #6014

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6813d84
Update ticker.py
afvincent Feb 17, 2016
6f9bf5f
Unit test on strings coming out of EngFormatter
afvincent Feb 17, 2016
ca341a5
Correct name for ticker in EngFormatter test
afvincent Feb 17, 2016
cf20132
PEP8 compliance
afvincent Feb 17, 2016
7724f09
New versions of (non) equality statements
afvincent Feb 18, 2016
6d584ad
Minor fix in the docstring.
afvincent Jun 5, 2016
2ab06c5
Fix a minor typo in EngFormatter docstring
afvincent Jun 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
PEP8 compliance 
Now “All right” on pep8online.com for the method format_eng in the class EngFormatter.
  • Loading branch information
@afvincent
afvincent committed Jun 5, 2016
commit cf201324e45fe64204a2ee561e9d6f99c9cac7cc
4 changes: 2 additions & 2 deletions lib/matplotlib/ticker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1112,11 +1112,11 @@ def format_eng(self, num):
format_str = ("%%.%if %%s" % self.places)

formatted = format_str % (mant, prefix)

formatted = formatted.strip()
if (self.unit is not "") and (prefix is self.ENG_PREFIXES[0]):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be == not is. It is just a little less brittle.

formatted = formatted + " "

return formatted


Expand Down