Skip to content

Check external links with linkchecker in docs build #6044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jenshnielsen
Copy link
Member

fixes #4205

@WeatherGod
Copy link
Member

I am a bit hesitant about this one. Could this get flakey if other sites
are down? Would it be better if we just made external link checking a part
of the release process?

On Mon, Feb 22, 2016 at 3:27 PM, Jens Hedegaard Nielsen <
notifications@github.com> wrote:


You can view, comment on, or merge this pull request online at:

#6044
Commit Summary

  • Check external links with linkchecker

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#6044.

@tacaswell tacaswell added this to the 2.1 (next point release) milestone Feb 22, 2016
@dopplershift
Copy link
Contributor

Speaking from experience, there are few things more annoying than having tests fail due to someone else's server. Also, it doesn't have to be the endpoint that's down, just a bad route (which happens on Travis more than you'd think).

@jenshnielsen
Copy link
Member Author

Lets see how it works. On the first run it has discovered that our favicon was broken because the link was incorrect

@jenshnielsen jenshnielsen mentioned this pull request May 23, 2016
@tacaswell tacaswell modified the milestones: 2.1 (next point release), 2.1.1 (next bug fix release) Sep 24, 2017
@tacaswell tacaswell modified the milestones: 2.1.1 (next bug fix release), 2.2 (next feature release) Oct 9, 2017
@jklymak
Copy link
Member

jklymak commented May 2, 2018

This seems stale - please reopen if needed!

@jklymak jklymak closed this May 2, 2018
@QuLogic QuLogic removed this from the needs sorting milestone May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure that Travis tests external links in docs, INSTALL, README etc.
7 participants