-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Patch issue #6035 #6054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Patch issue #6035 #6054
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f5fc2fa
First draft to correct issue #6035 and to write relevant unit tests. …
afvincent 5651a23
Achieve DPI-independent arrow heads in a cleaner way
afvincent a529161
Add a new unit test to check that a raw FancyArrowPatch is DPI-indepe…
afvincent 38e345a
Docstring fix
afvincent 0955cf9
Removed whitespaces (for PEP8)
afvincent 74eff0b
Added 2nd whitespace before inline comment (PEP8)
afvincent 903348a
Should fix broken unit tests 'polar_axes' and 'polar_coords' in test_…
6d2399f
Docstring/comments fixes & PEP8.
afvincent a552429
Docstring fix
afvincent 385917d
Update of failing PNGs in test_axes
afvincent c9faebe
New rebase and update of wrong PNG baseline images
afvincent 683214b
Update w/ PNGs produced on a computer (that should be) w/o fonts issue
afvincent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4056,7 +4056,7 @@ def __init__(self, posA=None, posB=None, | |
def set_dpi_cor(self, dpi_cor): | ||
""" | ||
dpi_cor is currently used for linewidth-related things and | ||
shrink factor. Mutation scale is not affected by this. | ||
shrink factor. Mutation scale is affected by this. | ||
""" | ||
|
||
self._dpi_cor = dpi_cor | ||
|
@@ -4065,7 +4065,7 @@ def set_dpi_cor(self, dpi_cor): | |
def get_dpi_cor(self): | ||
""" | ||
dpi_cor is currently used for linewidth-related things and | ||
shrink factor. Mutation scale is not affected by this. | ||
shrink factor. Mutation scale is affected by this. | ||
""" | ||
|
||
return self._dpi_cor | ||
|
@@ -4217,15 +4217,16 @@ def get_path_in_displaycoord(self): | |
patchB=self.patchB, | ||
shrinkA=self.shrinkA * dpi_cor, | ||
shrinkB=self.shrinkB * dpi_cor | ||
) | ||
) | ||
else: | ||
_path = self.get_transform().transform_path(self._path_original) | ||
|
||
_path, fillable = self.get_arrowstyle()(_path, | ||
self.get_mutation_scale(), | ||
self.get_linewidth() * dpi_cor, | ||
self.get_mutation_aspect() | ||
) | ||
_path, fillable = self.get_arrowstyle()( | ||
_path, | ||
self.get_mutation_scale() * dpi_cor, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this actually pass pep8? |
||
self.get_linewidth() * dpi_cor, | ||
self.get_mutation_aspect() | ||
) | ||
|
||
#if not fillable: | ||
# self._fill = False | ||
|
@@ -4535,13 +4536,14 @@ def get_path_in_displaycoord(self): | |
patchB=self.patchB, | ||
shrinkA=self.shrinkA * dpi_cor, | ||
shrinkB=self.shrinkB * dpi_cor | ||
) | ||
|
||
_path, fillable = self.get_arrowstyle()(_path, | ||
self.get_mutation_scale(), | ||
self.get_linewidth() * dpi_cor, | ||
self.get_mutation_aspect() | ||
) | ||
) | ||
|
||
_path, fillable = self.get_arrowstyle()( | ||
_path, | ||
self.get_mutation_scale() * dpi_cor, | ||
self.get_linewidth() * dpi_cor, | ||
self.get_mutation_aspect() | ||
) | ||
|
||
return _path, fillable | ||
|
||
|
Binary file added
BIN
+5.19 KB
...tplotlib/tests/baseline_images/test_arrow_patches/fancyarrow_dpi_cor_100dpi.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+11.2 KB
...tplotlib/tests/baseline_images/test_arrow_patches/fancyarrow_dpi_cor_200dpi.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-4 Bytes
(100%)
lib/matplotlib/tests/baseline_images/test_axes/polar_axes.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2 Bytes
(100%)
lib/matplotlib/tests/baseline_images/test_axes/polar_coords.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+734 Bytes
(100%)
lib/matplotlib/tests/baseline_images/test_streamplot/streamplot_colormap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+712 Bytes
(100%)
lib/matplotlib/tests/baseline_images/test_streamplot/streamplot_linewidth.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.78 KB
(100%)
lib/matplotlib/tests/baseline_images/test_streamplot/streamplot_masks_and_nans.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+61 Bytes
(100%)
lib/matplotlib/tests/baseline_images/test_streamplot/streamplot_startpoints.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+282 Bytes
(100%)
lib/matplotlib/tests/baseline_images/test_transforms/pre_transform_data.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just drop the 'not', in the near future no one will remember the old behavior and the
'now'
will just add confusion.