Skip to content

Attempt to fix issue #6000 Non-working 'set_visible' method for PatchCollection #6072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

wangx173
Copy link

https://github.com/matplotlib/matplotlib/issues/6000

the added code is to set "_visible" of all FancyArrowPatches of a PatchCollection to be False when "_visible" of PatchCollection has been set to False.

it fixed the non-working example mentioned in #6000, but I don't know if it is right, or there are other factors causing this issue

@tacaswell tacaswell added this to the 2.0.1 (next bug fix release) milestone Feb 29, 2016
@tacaswell
Copy link
Member

I do not think this is the right approach. The reason that the *Collection classes exist (as I understand it) is that they are a performance detail not strictly has a container for other Artists. That is to say, the bug reported by #6000 is not that set_visible on patch collection does not work, but that StreamPlot is not using the collection correctly.

@QuLogic QuLogic modified the milestones: 2.0.1 (next bug fix release), 2.0.2 (next bug fix release) May 3, 2017
@tacaswell tacaswell modified the milestones: 2.1.1 (next bug fix release), 2.2 (next feature release) Oct 9, 2017
@jklymak
Copy link
Member

jklymak commented May 17, 2018

Closing because approach deemed incorrect and no progress in 2+ y.

@jklymak jklymak closed this May 17, 2018
@story645 story645 removed this from the future releases milestone Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants