Modified scatter method to correctly recognize RGB/A values #6087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOC: linestyle is dash_dot and should be dashdot
Correct link to favicon
| @@ -3861,7 +3861,7 @@ def scatter(self, x, y, s=20, c=None, marker='o', cmap=None, norm=None, | |||
| # favor of mapping, not rgb or rgba. | |||
| try: | |||
| c_array = np.asanyarray(c, dtype=float) | |||
| if c_array.size == x.size: | |||
| if c_array.size == x.size and c_array.shape[0] != 1: | |||
There was a problem hiding this comment.
Is there anyway we can get a numpy-scaler in here as a valid input? If so probably want to be a bit more paranoid and add and carray.ndims
There was a problem hiding this comment.
and would the check on c_array.ndim == 1 be a better check?
Added images and links for seaborn, holoviews, and ggplot
Fix matplotlib#6069. Handle image masks correctly
This appears to be a backporting error. Closes matplotlib#6120
TST: pull test image from master branch
|
Yes, I think you are right. I hadn't noticed the existence of ndim previously. |
|
Can you please rebase onto current master (or at least current v2.x)? Merging upstream branches into feature branches causes problems, please do not do it. |
|
Closing this. There doesn't seem to be a good way to resolve this ambiguity, and it's already been discussed and notated in the comment in the code where this change is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #5377.
After being converted to a ndarray, the scatter method does not check if c_array is a 2D array (i.e. if we are passing RGB or RGB/A values.