Fix #6069. Handle image masks correctly #6099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alternative to matplotlib#6070 This works by converting the greyscale image to an RGBA image (with the alpha channel created correctly) prior to resizing in Agg. This also removes the hack (that caused problems with over/under) where we were using negative values to indicate transparency.
|
Passing Travis. Appveyor seems stuck in the queue. |
tacaswell
added a commit
that referenced
this pull request
Mar 4, 2016
Fix #6069. Handle image masks correctly
tacaswell
added a commit
that referenced
this pull request
Mar 4, 2016
Fix #6069. Handle image masks correctly
|
backported to v2.x as 1302606 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #6070
This works by converting the greyscale image to an RGBA image (with the
alpha channel created correctly) prior to resizing in Agg. This also
removes the hack (that caused problems with over/under) where we were
using negative values to indicate transparency.