Skip to content

#5856: added option to create vertically-oriented stem plots #6168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

#5856: added option to create vertically-oriented stem plots #6168

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6ca8063
#5856: added option to create vertically-oriented stem plots
vecuenca Mar 16, 2016
e93cd3e
Added docstrings for optional args in stem, made vertical default to …
vecuenca Mar 17, 2016
2b9e65f
Added flipping and renamed xs and ys in stem
vecuenca Mar 17, 2016
6c406f4
Changed orientation variable to string from boolean, also modified do…
ItsRLuo Mar 17, 2016
56fd706
Flipped thisx to thisy and vice versa when the orientation value is v…
ItsRLuo Mar 17, 2016
ed19281
Flipped x to y and vice versa for the baseline plot
ItsRLuo Mar 17, 2016
032ff4e
removed trailing whitespace
ItsRLuo Mar 17, 2016
9ed1e2e
Added some validation for the orientation arg in stem()
vecuenca Mar 21, 2016
9570dfa
Added whats_new entry for #5856
vecuenca Mar 22, 2016
bd7c878
Added stem orientation test and associated baseline images
vecuenca Mar 22, 2016
b161f18
Fixed whats_new entry
vecuenca Mar 24, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added some validation for the orientation arg in stem()
  • Loading branch information
@vecuenca
vecuenca committed Mar 21, 2016
commit 9ed1e2ebc187747ddb51a7979193eef37f0460a0
3 changes: 3 additions & 0 deletions lib/matplotlib/axes/_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2448,6 +2448,9 @@ def stem(self, *args, **kwargs):
# wants a vertical or horizontal stem plot
orientation = kwargs.pop('orientation', 'horizontal')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably do some validation here to make sure 'aardvark' or the like does not get passed in.


if orientation not in ('horizontal', 'vertical'):
raise ValueError("'%s' is not a valid orientation" % orientation)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a bigger change, but could you refactor this to have on if block up here which does the flipping (and maybe rename x, y?) and then the rest of the logic is the same.

bottom = kwargs.pop('bottom', None)
label = kwargs.pop('label', None)

Expand Down