BLD: make minimum cycler version 0.10.0 #6340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
attn @WeatherGod I think we did not backport those changes to 2.x so I do not think this needs to be backported either. |
|
In that case I think 2.x should run the tests with cycler 0.9 on Travis as 1.5.x does |
|
Also need to update |
|
@WeatherGod update what else in setupext.py? |
|
Sorry, let me clarify... in my PR, I updated |
|
I could not find anything in the code that did any version checking on cycler last night (which confused me). Maybe we lost it in a bad merge? |
|
The faulty PR is #6275. It was backported to 2.x. |
|
🐑 I forgot to update my local master before forking this branch, stand by. |
29df8ad to
e92eb88
Compare
WeatherGod
added a commit
that referenced
this pull request
Apr 27, 2016
BLD: make minimum cycler version 0.10.0
|
backported as 9f83d53 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6325