Avoid duplicate cmap in image options. #6346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation was incorrect and would yield a double entry in the cmap combobox.
| @@ -137,7 +137,7 @@ def prepare_data(d, init): | |||
| for label in imagelabels: | |||
| image = imagedict[label] | |||
| cmap = image.get_cmap() | |||
| if cmap not in cm.cmap_d: | |||
There was a problem hiding this comment.
would it be better to check that cmap.name not in cm.cmap_d?
There was a problem hiding this comment.
I thought someone could accidentally create a custom cmap with the same name as one in cmap_d (although it's a pretty theoretical risk and it'd make the combobox awkward anyways), so checking on cmap identity should be safer.
|
👍 on this. RE my comment; I do not have an opinion one way or the other, just curious why you picked this implementation. |
This was referenced Jul 10, 2016
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation (#5469) was incorrect and would yield a double entry
in the cmap combobox.