API: bar now color cycles #6364
Conversation
| @@ -1975,6 +1975,8 @@ def bar(self, left, height, width=0.8, bottom=None, **kwargs): | |||
| if not self._hold: | |||
| self.cla() | |||
| color = kwargs.pop('color', None) | |||
| if color is None: | |||
There was a problem hiding this comment.
We are going to need to do the keyword normalization prior to this step. How do we want to coordinate this with the normalization PR?
There was a problem hiding this comment.
do you touch bar in that PR?
The kwarg normalization should probably be done via a decorator.
There was a problem hiding this comment.
bar is not touched in that PR. Only plot() and fill(), however, that does indirectly impact a lot of other plotting functions since they serve as the basis for many others. I don't think bar() calls fill(), though.
As for normalizing via kwargs, I'd agree, in general. We would need to be careful on any collisions with other kwargs, and if there are any organically-grown alias-handling logic that would need to be cleaned up as well.
There was a problem hiding this comment.
still needs kwarg normalization
There was a problem hiding this comment.
Done but used a different set of aliases. Passing in c currently does not work, no reason to let it start working.
5fb3a58 to
572e0da
Compare
|
Needs a rebase now |
repeated calls to `ax.bar` will advance the patch color cycle. closes matplotlib#5854
572e0da to
5a7dab7
Compare
|
rebased. |
|
restarted the failing test, but I am not sure it is a transient failure. It doesn't seem related, though. |
|
FAIL: matplotlib.tests.test_backend_pdf.test_hatching_legend.test is the failed test, restarted again. |
repeated calls to
ax.barwill advance the patch color cycle.closes #5854
attn @story645