Skip to content

Sort default labels numerically in Qt editor. #6366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2016
Merged

Sort default labels numerically in Qt editor. #6366

merged 1 commit into from
May 5, 2016
+11 −2

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 5, 2016

See #6315.

@tacaswell tacaswell added this to the 2.1 (next point release) milestone May 5, 2016
@tacaswell
Copy link
Member

I still think padding the default label with 0 would be simpler, but this is much less disruptive (no API change) and works to (unreasonably) large numbers of lines/images. This is much better than what I suggested.

👍

Can you add a note to the whats new being accumulated in #6361?

merging despite failing tests as a) the test failures are due to a blue -> black default change and b) this code path is not tested.

@tacaswell tacaswell merged commit 0c07515 into matplotlib:master May 5, 2016
@anntzer anntzer deleted the sort-line-and-image-labels-numerically branch May 5, 2016 16:27
@anntzer
Copy link
Contributor Author

anntzer commented May 5, 2016

How should I do this? Should I PR on your repo?

@tacaswell
Copy link
Member

That would work, or just put in a new PR with more commits on top of that
branch (and I will close my PR).

On Thu, May 5, 2016 at 12:30 PM Antony Lee notifications@github.com wrote:

How should I do this? Should I PR on your repo?

—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
#6366 (comment)

@QuLogic QuLogic added the GUI: Qt label May 5, 2016
This was referenced Jul 10, 2016
Merged
Closed
Merged
@QuLogic QuLogic modified the milestones: 2.0 (style change major release), 2.1 (next point release) Jul 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
GUI: Qt
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @tacaswell @mdboom @QuLogic