Skip to content

Fix canonical name for "None" linestyle. #6381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 8, 2016

The canonical "empty" linestyle is "None", not "none". The previous
implementation would raise an error after running

plot([1, 2], ls="none")

and opening the figure options editor.

The canonical "empty" linestyle is "None", not "none".  The previous
implementation would raise an error after running

    plot([1, 2], ls="none")

and opening the figure options editor.
@WeatherGod
Copy link
Member

Really? I always thought that we promoted the lowercase form to reduce
confusion with the python None.
On May 7, 2016 8:17 PM, "Antony Lee" notifications@github.com wrote:

The canonical "empty" linestyle is "None", not "none". The previous
implementation would raise an error after running

plot([1, 2], ls="none")

and opening the figure options editor.

You can view, comment on, or merge this pull request online at:

#6381
Commit Summary

  • Fix canonical name for "None" linestyle.

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#6381

@anntzer
Copy link
Contributor Author

anntzer commented May 8, 2016

I agree that "none" would have been preferable, but both on 1.5.1 and master:

In [1]: plt.plot([1, 2], ls="none")[0].get_linestyle()
Out[1]: 'None'

@QuLogic QuLogic added the GUI: Qt label May 8, 2016
@tacaswell tacaswell added this to the 2.1 (next point release) milestone May 8, 2016
@anntzer
Copy link
Contributor Author

anntzer commented Jul 8, 2016

Bumping.
Hopefully this can make it to 2.0? Again it should be a straight, non-controversial bug fix.
We can always switch the "canonical" none-linestyle as lowercase "none" later (which I'd prefer... modulo back-compatibility issues); we'd just need to revert this PR if that happens.

@tacaswell tacaswell modified the milestones: 2.0 (style change major release), 2.1 (next point release) Jul 8, 2016
@tacaswell
Copy link
Member

The failure on building the docs seems to be persistent, but not showing up anywhere else.

@tacaswell tacaswell merged commit 7206ae7 into matplotlib:master Jul 9, 2016
tacaswell added a commit that referenced this pull request Jul 9, 2016
…inestyle

Fix canonical name for "None" linestyle in qtconfig gui
@tacaswell
Copy link
Member

backported to v2.x as f7aa7b3

@anntzer anntzer deleted the figure-options-canonical-none-linestyle branch July 9, 2016 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants