-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Qt editor alpha #6383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qt editor alpha #6383
Conversation
@anntzer this needs a rebase after your other PR got merged. |
Nope, it's still fine. |
github/The web UI disagrees with you about this needing a rebase. |
Sorry, I was confused by your message on the other PR regarding it being pulled in (which is not the case). Anyways, rebased both PRs. |
9c01ad3
to
abb3e5e
Compare
By the way, I would appreciate if someone did some manual testing of this PR too, because the figure options UI is not unit-tested (and that would not be so easy to do...). |
👍 does what it says on the tin. Looks like this needs a rebase. |
Apparently I also needed to call |
If I change those lines back to |
What did you try? If I call |
Ah, I was starting with a full alpha line and then turning it down. |
Ping? Milestone changed to match with #6382. |
Should be good to go? The issue with the need to explicitly call |
Hmm, this doesn't backport cleanly. Do you mind opening another PR for it? |
Should I cherry-pick this to upstream/v2.x? |
Yes, it just doesn't do so cleanly. I'm sure you'll be able to figure it out though. |
@anntzer Go ahead and backport all of the editor code if that is easier. |
Make alpha values accessible through the Qt figure options editor. Requires #6382 (alpha support in
matplotlib.colors
), closes #6196.