Animation error handling (Fixes #6416) #6441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When passed arguments that are only used when creating a new MovieWriter instance, raise an error if writer is an existing instance rather than silently ignoring the arguments. Also document the fact that these arguments are invalid in that case.
| raise | ||
| raise IOError('Error saving animation to file. ' | ||
| 'Stdout: {0} StdError: {1}. It may help to re-run ' | ||
| 'with --verbose-debug.'.format(out, err)) |
There was a problem hiding this comment.
The original exception is now getting swallowed. Would probably be nice to at least have it logged through verbose.report()?
There was a problem hiding this comment.
I think it's even better to just include it in the new exception message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the remaining issues from #6416
MovieWriter)The latter can only be improved so much, because often the observed behavior is a
BrokenPipeError, which keeps us from being able to grab anything from stderr. My solution here is to note that running with--verbose-debugmay be helpful since in this case output is dumped straight to stdout.