Skip to content

Subplot spacing #6468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 28, 2016
Merged

Subplot spacing #6468

merged 3 commits into from
May 28, 2016

Conversation

tacaswell
Copy link
Member

Replaces #6129

@efiring
Copy link
Member

efiring commented May 28, 2016

This has a bunch of image failures. Some of them I recognize as trouble-makers from earlier style changes. I'm not sure whether the best solution is just replacing the images.

@tacaswell
Copy link
Member Author

Digging into why these are failing is on my list of things to do today.

On Sat, May 28, 2016, 14:03 Eric Firing notifications@github.com wrote:

This has a bunch of image failures. Some of them I recognize as
trouble-makers from earlier style changes. I'm not sure whether the best
solution is just replacing the images.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#6468 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAMMhcBesWznV5Un9AA24LbBtbk09OAWks5qGINmgaJpZM4IkzRk
.

@tacaswell
Copy link
Member Author

3 of the tests that explicitly use the new defaults and 4 of them are the pgf tests.

I think that until we tag 2.0, the image comparison should just knownfail any non-'classic' style test.

@tacaswell
Copy link
Member Author

Assuming this passes it should be ready to go. The other default change PRs should probably be rebased to also side-step some of this pain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants