FIX: minimum number of bins in 'auto' is 3 #6470
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to prevent plots with only one visible tick. Use 3 instead of 2 because ticks may fall out of the visible range so 2 bins would be 3 ticks which may be one visible and 2 off either end.
|
This doesn't do the job because nbins is just a maximum; there is nothing in place to enforce a minimum. The locator is still stuck trying to shoehorn in as many ticks as it can, up to the max, given all the other constraints. If we want MaxNLocator to serve as a Max_and_Min_NLocator then we will need to add some sort of fallback logic: if the normal route yields fewer than the minimum number of ticks, back off on a constraint (such as the max) and try again, until the minimum is obtained. |
|
Your right. It might make it less likely to do the wrong thing, will not guarantee it will always do the right thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prevent plots with only one visible tick.
Use 3 instead of 2 because ticks may fall out of the visible range so 2
bins would be 3 ticks which may be one visible and 2 off either end.
closes #5784