Mnt cn passthrough #6499
Merged
Mnt cn passthrough #6499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validation on the rcParams means that `rcParams['axes.prop_cycle']` can never be None.
- _transpose() -> by_key() - be pedantic about return types
|
also @WeatherGod was right, this is a horrible can of worms. |
|
Leaving out the last commit, we have what I think we agreed on a while back: C0 is defined as the first color in the global color cycle. 98% of users will stick with the global cycle, and the remaining 2% are presumably sophisticated enough to figure out what to do to get their desired effect. |
5e77085 to
dfa14fe
Compare
|
@efiring done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to close #6380
The first 4 commits on this are relatively un-controversial. They
_base.pyhowever this changes the 'default' line color back to 'C0' which resolves to 'b' in the global prop_cycler so change the tests to specify 'k' as the color to keep the test passing.The 5th commit makes
to_rgbatake in a cycler to use for local CN look up. In the cases where we are going through_process_plot_formatin_get_lineswe can easily get theAxesproperty cycler in, however in many other cases where we want to useCN(such as inLine2Dwhich gets it's default color from rcparam, which may be'CN'and actually callsto_rgbaat some later point) may not even be associated with anAxesobject so whenCNgets resolved so it has to use the global property cycler. With the 5th commit we have the situation where if the user lets the color be'C0'via the call or via the rcparams, there will be different results.Having typed this out I am inclined to rip that commit off, but leaving for comment.
I would be comfertable doing the beta having with the first 4 commits merged, but not the 5th.