Use subprocess32 on python 2.7 #6576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| __all__ = ['Popen', 'PIPE', 'STDOUT', 'check_output', 'CalledProcessError'] | ||
|
|
||
|
|
||
|
|
|
ping on this |
77a5ddd to
a9a6507
Compare
|
Rebased and fixed comments |
| except ImportError: | ||
| return ( | ||
| "subprocess32 was not found. It used for " | ||
| " for python versions prior to 3.2 to improves" |
There was a problem hiding this comment.
The double for is still here. Should be Python.
And use it in plase of subprocess on posix systems.
a9a6507 to
4b36ce4
Compare
|
This is failing because lib/matplotlib/compat/subprocess.py passes pep8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #5314
Subprocess32 should fix the insecure string pickle error in python2.7 on OSX as seen in #5314 however the package is only tested on posix systems so don't use it on windows.