Skip to content

FIX: cast return of contains_points to bool #6654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2016
Merged

FIX: cast return of contains_points to bool #6654

merged 1 commit into from
Jun 28, 2016

Conversation

tacaswell
Copy link
Member

Closes #6566

@tacaswell tacaswell added this to the 1.5.2 (Critical bug fix release) milestone Jun 28, 2016
@QuLogic
Copy link
Member

QuLogic commented Jun 28, 2016

For point of reference, I ran #6444 against this and v1.5.x, with times of 0.0750±0.0012 and 0.0741±0.0008 over ten runs. Not super scientific, but I think enough to say it's not going to cause the same sort of performance regression.

@jenshnielsen jenshnielsen merged commit 588b748 into matplotlib:v1.5.x Jun 28, 2016
@jenshnielsen jenshnielsen mentioned this pull request Jun 28, 2016
Closed
@tacaswell tacaswell deleted the mnt_points_contain_return_bool branch June 28, 2016 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@tacaswell @QuLogic @jenshnielsen