FIX: support np.flatiter is input again #6712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2544,6 +2544,15 @@ def index_of(y): | |||
|
|
|||
| def safe_first_element(obj): | |||
| if isinstance(obj, collections.Iterator): | |||
| # needed to accept `array.flat` is input. | |||
There was a problem hiding this comment.
is -> as
And while I make that comment, the commit message also needs the same fix.
This was unintentionally broken by bdaaf59 which went in as part of PR matplotlib#5556 which was fixing support for pandas series.
03473e0 to
8d03299
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was unintentionally broken by
bdaaf59 which went in as part of
PR #5556 which was fixing support for pandas series.