Skip to content

Fixed warnings catching and counting with warnings.catch_warnings #6761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2016
Merged

Fixed warnings catching and counting with warnings.catch_warnings #6761

merged 1 commit into from
Jul 16, 2016

Conversation

Kojoley
Copy link
Member

@Kojoley Kojoley commented Jul 16, 2016

No description provided.

@Kojoley Kojoley mentioned this pull request Jul 16, 2016
Closed
39 tasks
@tacaswell
Copy link
Member

This makes sense but what motivated this change?

@tacaswell tacaswell added this to the 2.1 (next point release) milestone Jul 16, 2016
@Kojoley
Copy link
Member Author

Kojoley commented Jul 16, 2016 •
edited
Loading

pytest fails on test_axes.test_eventplot_problem_kwargs test and I have discovered that this issue actually persists in other places too, so after that I have fixed all the warnings.catch_warnings uses but have struck on test_figure.test_too_many_figures test that currently does not even work (it raises two warnings with range(22), but not one).

@tacaswell
Copy link
Member

pep8 is fixed on master already.

Not bothering to wait for appveyor, it is super backed up today

@tacaswell tacaswell merged commit 6d339ed into matplotlib:master Jul 16, 2016
@QuLogic
Copy link
Member

QuLogic commented Jul 16, 2016

Would any of these need backporting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@Kojoley @tacaswell @QuLogic @mdboom