Only call dirname on string-like directory names #677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think a positive report from @gujax should be sufficient. |
|
gujax did report that the fix worked, but was concerned that we are skipping useful data. Should we still go ahead with this patch? My vote is yes, but we should probably leave some comments in the code pointing out that there have been reports of non-string values coming back from the registry and may be an indicator of a bug elsewhere? |
jdh2358
added a commit
that referenced
this pull request
Feb 26, 2012
Only call dirname on string-like directory names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In issue 672 @gujax reports that the registry includes an entry where the value is numeric, not a string, and os.path.dirname crashes. This should avoid that problem, but I don't have a Windows system to test on.