2.0 Examples fixes. See #6762 #6786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are fixes for all issues found in axes_grid, color, and event_handling sections on the examples page. axis_grid/demo_colorbar_with_inset_locator.py - changed interpolation from the default(previously bilinear now none) to 'bilinear' to match 1.5.1 example axes_grid1/simple_axesgrid.py - set interpolation to bilinear axisartist/demo_curvelinear_grid.py - Set linewidth=2.0 and grid zorder=0 so the plotted lines actually visible event_handling/keypress_demo.py - added usage instruction as axes title event_handling/lasso_demo.py - added usage instruction as axes title event_handling/looking_glass.py - added usage instruction as axes title event_handling/resample.py - removed gtk and hardcoded wave file dependencies and just created a sample signal within the script event_handling/trifinder_event_demo.py - zip(l1,l2) call changed to list(zip(l1,l2)) to be python3 compatible event_handling/viewlims.py - The focus box that is supposed to appear in the left axes when user zooms in the right axes wasn't visible. Set linewidth=1.0
|
Thanks! I am 👎 on changing the examples back to bilinear. It looks like this put a bunch of pep8 issues in We decided a long time ago to enforce a code style via the package formally known as pep8. If I recall correctly, you use emacs. I suggest installing elpy in emacs and flake8 in your python enviroment to get pep8 linting in emacs. |
These are fixes for all issues found in axes_grid, color, and event_handling sections on the examples page. axisartist/demo_curvelinear_grid.py - Set linewidth=2.0 and grid zorder=0 so the plotted lines actually visible event_handling/keypress_demo.py - added usage instruction as axes title event_handling/lasso_demo.py - added usage instruction as axes title event_handling/looking_glass.py - added usage instruction as axes title event_handling/resample.py - removed gtk and hardcoded wave file dependencies and just created a sample signal within the script event_handling/trifinder_event_demo.py - zip(l1,l2) call changed to list(zip(l1,l2)) to be python3 compatible event_handling/viewlims.py - The focus box that is supposed to appear in the left axes when user zooms in the right axes wasn't visible. Set linewidth=1.0
|
Removed the bilinear mods and corrected the pep8 issues @tacaswell |
|
🎉 Congratulations on what (I think) is your first contribution to mpl! Documentation is someplace that we do not put enough effort into and this work is greatly appreciated. |
tacaswell
added a commit
that referenced
this pull request
Jul 19, 2016
DOC: 2.0 Examples fixes See #6762
|
backported to v2.x as 2bf445d |
|
The backport is actually 8396451. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are fixes for all issues found in axes_grid, color, and
event_handling sections on the examples page.
axisartist/demo_curvelinear_grid.py - Set linewidth=2.0 and grid zorder=0 so
the plotted lines actually visible
event_handling/keypress_demo.py - added usage instruction as axes title
event_handling/lasso_demo.py - added usage instruction as axes title
event_handling/looking_glass.py - added usage instruction as axes title
event_handling/resample.py - removed scikits and hardcoded wave file dependencies
and instead create a sample signal within the script
event_handling/trifinder_event_demo.py - zip(l1,l2) call changed to
list(zip(l1,l2)) to be python3 compatible
event_handling/viewlims.py - The focus box that is supposed to appear in the
left axes when user zooms in the right axes wasn't visible. Set linewidth=1.0