Skip to content

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 24, 2016

Because, why not?

@tacaswell tacaswell merged commit b5b5a67 into matplotlib:master Jul 28, 2016
@QuLogic QuLogic added this to the 2.1 (next point release) milestone Jul 28, 2016
@Kojoley
Copy link
Member

Kojoley commented Jul 28, 2016

This does not work 😕
There is no files in coverage report from mpl_toolkits, file count is the same and coverage not changed. I think it is because of this line.
But even with such fix coverage report will be fooled, because nose does not report uncovered files (you can compare with this report from pytest-cov)

@jenshnielsen
Copy link
Member

I think @Kojoley is right. I setup the original coverage but there are lots of issues with it and I have been postponing to change it until we have converted to pytest

@anntzer
Copy link
Contributor Author

anntzer commented Jul 28, 2016

Ahh... OK, let's just wait for the conversion to pytest first then.

@anntzer anntzer deleted the add-mpl_toolkits-to-coverage branch July 28, 2016 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants