-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fix for PyQt5.7 support. #6854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for PyQt5.7 support. #6854
Conversation
Just getting rid of a slot with an incorrect signature (for which PyQt5.7 is more strict). Tested on PyQt5.6.1 and 5.7, PyQt4.11.4, PySide 1.2.4.
How did you track down that comment? |
Fix: bad slot signature for Qt closes #6853
backported to v2.x as 6ab5475 |
git blame to see which PR that line came from... |
Hi, |
The 1.5 line is nearing its end. Apart from one last bugfix release, which will be 1.5.3, the line of development goes to 2.x, for which a 2.0 release is anticipated quite soon, and then master, which will be the origin of an eventual 2.1 release--but not soon. The fix in this PR is in master and in 2.x, so if you installed master you should have it. It sounds like it should be backported to 1.5.3. The immediate question, though, is why you are still getting the error if you have installed master. Is it possible that you are seeing a similar error, but not exactly the same one? Or that the python you are using is not the one into which mpl master was installed? |
Hi, |
Actually, I now think that this issue is annoying enough to warrant a bugfix release asap (say 1.5.2.1 and possibly 2.0b4, respectively based on 1.5.2 and 2.0b3, with only this additional patch in), except if the next releases are planned for very soon. |
there is a (sadly) growing list of things to backport to a 1.5.3 |
I'm seeing this problem with matplotlib 1.5.2, which is the current version that installs with |
Fix: bad slot signature for Qt closes #6853
backported to 1.5.x as 3d2872e |
I just synced my fork with master, and now I have this problem as well, after a bunch of gtk warnings. Apparently it should not be happening anymore. The version shows In the notebook it works fine though. |
Thanks, how can I fix it? rebase again? |
@rmlopes Yes, rebase + force push should fix this. |
Could it be that I'm seeing the same error under Fedora 25?
|
Yes, you have a version of Matplotlib that pre-dates this fix (went out the door in 1.5.3). |
Ah, so not backported to 1.5.2.x then I suppose? |
There is no 1.5.2.x Matplotlib has at most 3 release levels. The official releases of the 1.5.x series were: 1.5.0, 1.5.1, 1.5.2 and 1.5.3. Anything else is done by fedora maintainers. They may chose to backport patches to their packages but that is completely up to them. |
Just getting rid of a slot with an incorrect signature (for which
PyQt5.7 is more strict).
Tested on PyQt5.6.1 and 5.7, PyQt4.11.4, PySide 1.2.4.
cf #6853.
@tacaswell you already suggested the correct fix a year ago :) (#4894 (comment))
Given that without this fix, matplotlib doesn't work at all with PyQt5.7, I'm milestoning to 2.0; this should probably also be backported to 1.5.3 (1.5.2 if it gets retagged).