Prevent forced alpha in figureoptions. #6895
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forcing the alpha value sets it not only for the line color but also the marker faces and edges (i.e., editing the alpha value of the markers in the options editor had no effect). Instead, just remove any forced alpha and use the alpha values that have been set in the editor. A later idea may be to make alpha not override alpha values passed in together with the color as quadruplets.
|
This has the effect of over-ridding any previously supplied user input, but that is ok as they are in the editor (and the way it was is also throwing away user input), so merging. |
tacaswell
added a commit
that referenced
this pull request
Aug 4, 2016
…ptions FIX: Prevent forced alpha in figureoptions.
|
backported to v2.x as 5fb9017 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forcing the alpha value sets it not only for the line color but also the
marker faces and edges (i.e., editing the alpha value of the markers
in the options editor had no effect). Instead, just remove any forced
alpha and use the alpha values that have been set in the editor.
A later idea may be to make alpha not override alpha values passed in
together with the color as quadruplets.
See discussion starting at #6383 (comment)