Rework MaxNLocator, eliminating infinite loop; closes #6849 #6919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here also, the appveyor py 3.5 build failed early on; it's unrelated to this PR. |
| # Make an extended staircase within which the needed | ||
| # step will be found. This is probably much larger | ||
| # than necessary. | ||
| flights = (0.1 * np.array(self._steps[:-1]), |
|
This leads to (or the example in #6849) even though the ticker could very well just use the two ticks at the two integer values. |
tacaswell
added a commit
that referenced
this pull request
Aug 22, 2016
ENH: Rework MaxNLocator, eliminating infinite loop; closes #6849
|
backported to v2.x as 9982e40 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core algorithm has been reimplemented in a more compact and understandable form than my earlier try at adding the
min_n_ticksconstraint.I replaced the images for one mplot3d test because I think the present behavior is more consistent than the earlier behavior that led to those images. In the replaced versions, all of the axes have ticks just slightly inside the limits. Based on the gallery it appears this is the intended behavior but @WeatherGod can confirm or deny this.