Skip to content

FIX: guard against numpy warnings #6971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2016

Conversation

tacaswell
Copy link
Member

Do not try to compare a string to an array.

closes #6970

Do not try to compare a string to an array.

closes matplotlib#6970
@tacaswell tacaswell added this to the 2.0.1 (next bug fix release) milestone Aug 24, 2016
@WeatherGod
Copy link
Member

looks good to me.

@efiring
Copy link
Member

efiring commented Aug 24, 2016

This is fine and I'm on the edge of pressing the button, but... I think that adding the test is overkill. Here's the larger issue: test code is still code, still subject to bugs, still a potential cause of puzzlement among developers, still something that needs maintenance. The test here is for a very specific problem that has been solved in a general and obvious way--there are probably hundreds of similar places in the code where problems like this have been solved, or never arose, and it would do us no good to put in tests for them. Similarly, I think that in the long run having this test included will be a net drag, not a net gain, for the development and maintenance process.

@efiring
Copy link
Member

efiring commented Aug 24, 2016

Aha, I didn't update my web page before writing that comment, so I see my point is moot for this PR. Nevertheless, I think that this issue of how to ensure our test suite is lean and effective, and minimally puzzling, is something we need to consider more carefully in the future.

@QuLogic QuLogic modified the milestones: 2.0 (style change major release), 2.0.1 (next bug fix release) Aug 24, 2016
@tacaswell
Copy link
Member Author

@efiring Want me to open a PR to remove that test?

@efiring
Copy link
Member

efiring commented Aug 26, 2016

Only if you agree with my rationale and feel motivated. We can discuss this on Monday if you like. It's really more the big picture that I'm concerned about.

@tacaswell
Copy link
Member Author

I also half-viewed those tests as a down-payment on more through quiver tests (as this was a code path we do not otherwise touch) so it is getting us some additional (smoke-test) coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants