Skip to content

[WIP] Close #6968 make autoscale respect tight #7024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[WIP] Close #6968 make autoscale respect tight #7024

wants to merge 2 commits into from

Conversation

jenshnielsen
Copy link
Member

The test is currently broken. For reasons that I don't understand yet the margin does not seem to be applied at all in the tests.

@jenshnielsen jenshnielsen added this to the 2.0 (style change major release) milestone Sep 4, 2016
@jenshnielsen jenshnielsen changed the base branch from master to v2.x September 4, 2016 21:04
@tacaswell
Copy link
Member

I suspect it is because the test all run in 'classic' mode with that feature disabled.

@jenshnielsen
Copy link
Member Author

Yes I realised that too after pushing. Will fix

@tacaswell
Copy link
Member

Non-classic tests are currently skipped because #6757 has stalled.

@jenshnielsen
Copy link
Member Author

Only if they are image comparison right? This fails other tests. Have not had the time to investigate why yet.

@tacaswell tacaswell added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Sep 12, 2016
@NelleV
Copy link
Member

NelleV commented Sep 20, 2016

I confirm @tacaswell's diagnostic. The tests run fine on my computer on your branch after a rebase + using default style (on the two tests I've executed). Apart from the failing tests that should be quite straightforward to fix, this patch looks good!

@tacaswell tacaswell closed this Sep 20, 2016
@tacaswell tacaswell reopened this Sep 20, 2016
@tacaswell
Copy link
Member

tacaswell commented Sep 25, 2016 •
edited by dopplershift
Loading

The problem is that if you explicitly use ax.margins it (eventually) sets ax._tight to True to disable the previous default of 'round' numbers.

This is going to take a while to pick apart...

@tacaswell
Copy link
Member

xref #6968

@efiring
Copy link
Member

efiring commented Nov 7, 2016

I think I see the problem and how to solve it; I will propose an alternative PR within a few days.

@efiring efiring self-assigned this Nov 10, 2016
@efiring efiring mentioned this pull request Nov 14, 2016
Merged
@efiring
Copy link
Member

efiring commented Nov 14, 2016

closing; replaced by #7458

@efiring efiring closed this Nov 14, 2016
@jenshnielsen jenshnielsen deleted the fixtight_autoscale branch November 30, 2016 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@efiring efiring

Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jenshnielsen @tacaswell @NelleV @efiring @QuLogic