NonUniformImage : conversion to RGB array is now done inside *make_image* method. #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age* method. Fixes # 708.
efiring
added a commit
that referenced
this pull request
Mar 17, 2012
NonUniformImage : conversion to RGB array is now done inside *make_image* method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix #708.
For NonUniformImage, conversion to RGB array have been done during set_data. Therefore, changes in clim of cmap has no effect until you reset the data. This PR moves the relevant code to make_image method.
This fixes the problem as the conversion is done whenever image is drawn.
While this gives you a consistent behavior with a normal AxesImage, it is ineffective as caching is not effectively done.