-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
DOC: changed documentation for axvspan to numpydoc format #7267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
%(Polygon)s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're still removing this here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The consensus is that the links are a better option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the general consensus to move away from these, and have nicer documentation on the artists themselves. At least that's what I understood from different conversation, even during the matplotlib call or on tickets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may document this in a MEP somewhere.
---------------- | ||
**kwargs | ||
Optional parameters are properties of the class | ||
matplotlib.patches.Polygon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should link?
|
||
.. seealso:: | ||
>>> axvspan(1.25, 1.55, facecolor='g', alpha=0.5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the consensus on the style and "completeness" of examples like this?
My thought is that something like:
import matplotlib.pyplot as plt
fig, ax = plt.subplots()
ax.axvspan(1.25, 1.55, facecolor='g', alpha=0.5)
plt.show()
or a link to the gallery/examples would be better.
I don't feel very strongly about that, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that a full runnable example would be much better. I am not a big fan of links in the gallery as they are only good for sphinx rendered documentation, but do not render properly in terminal docstring.
|
||
:meth:`axhspan` | ||
for example plot and source code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the See Also
sections are helpful. But I'd understand if they're a pain to maintain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wasn't removed; it just got a numpydoc heading instead of a sphinx one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh yes. I see that now.
DOC: changed documentation for axvspan to numpydoc format
backported to v2.x as 05fec77 |
Updated documentation of axvspan function to numpydoc format, as part of a project during the ASPP2016 Summer School
supersedes #7039 (fixes the pep8 compliancy issues).