Skip to content

MEP28: fix rst syntax for code blocks #7309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2016

Conversation

phobson
Copy link
Member

@phobson phobson commented Oct 19, 2016

I borked the python code blocks in my MEP.

(they were interpreted as comments)

Small changes to fix that.

@phobson
Copy link
Member Author

phobson commented Oct 19, 2016

@jenshnielsen thanks for the quick turn around on the doc build this morning. Sorry I messed this up.

@tacaswell
Copy link
Member

devdocs is built by travis and push everytime we merge to master. @jenshnielsen does sleep, but this process uses his keys (which I think we can now switch to an org deploy key but this works so lets not touch it).

@NelleV
Copy link
Member

NelleV commented Oct 19, 2016

There's a tool to build and push for each branch as well. I forgot the name, but @Carreau should know. That may help in getting our build more consistent?

@jenshnielsen
Copy link
Member

It's just using a key that I generated for this purpose (I guess it must contain my mail address but should probably be using one of the mailing lists instead) That key is added as a deploy key with write access for https://github.com/matplotlib/devdocs but no where else (github prevents you from using deploy keys more than once in their system). We build the docs for every branch but only deploy from master. We could extend this to other branches (2.x ...) but it would not be safe to automatically docs builds from PRs as far as I can see (anyone can open a PR and inject malware into the build docs).

Travis-sphinx can do much the same using an API key which would probably make it easier to build from multiple branches

@tacaswell tacaswell merged commit c93dff4 into matplotlib:master Oct 20, 2016
@phobson phobson deleted the MEP28-code-fix branch October 20, 2016 14:32
@phobson
Copy link
Member Author

phobson commented Oct 20, 2016

@tacaswell unless there are objections, I'll announce this on the mailing list shortly.

@phobson
Copy link
Member Author

phobson commented Oct 20, 2016

(also thanks for the merge!)

@QuLogic QuLogic added this to the 2.1 (next point release) milestone Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants