TST: Fixed rcparams test_Issue_1713 test
#7328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6ea55c0 to
e5cb3a6
Compare
QuLogic
reviewed
Oct 22, 2016
| @@ -224,16 +228,13 @@ def test_legend_edgecolor(): | |||
| yield _legend_rcparam_helper, rc_dict, target, get_func | |||
|
|
|||
|
|
|||
| def test_Issue_1713(): | |||
| def test_unicode_parsing(): | |||
There was a problem hiding this comment.
UTF-8 is also Unicode (sort of), so this test is not really for just Unicode, per se.
There was a problem hiding this comment.
Yes, but it what the #1713 title says.
There was a problem hiding this comment.
I think that's more a symptom of Python 2-ness, "Unicode vs str", but it's not strictly correct.
There was a problem hiding this comment.
I much preferred the new title than the old.
e5cb3a6 to
70285e1
Compare
test_Issue_1713 test
NelleV
approved these changes
Oct 25, 2016
test_Issue_1713 testtest_Issue_1713 test
test_Issue_1713 testtest_Issue_1713 test
QuLogic
pushed a commit
that referenced
this pull request
Oct 25, 2016
TST: Fixed rcparams `test_Issue_1713` test
|
Backported to v2.x via 6dbbb98. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the monkey-patching there is no good way to change locale on Windows (LANG env variable has no effect on it).
I also renamed the test to a meaningful name.
Closes #7281