Skip to content

FIX symlog scale now shows negative labels. #7337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2016
+5 −5
Merged

FIX symlog scale now shows negative labels. #7337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d52675f
FIX symlog scale now shows negative labels.
NelleV Oct 23, 2016
46083bf
FIX more fixes for tickers
NelleV Oct 24, 2016
0199251
FIX negative value for log formatter is now better dealt with
NelleV Oct 24, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/matplotlib/tests/test_ticker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
from __future__ import (absolute_import, division, print_function,
unicode_literals)

import six

from numpy.testing import assert_almost_equal
import numpy as np
import pytest
Expand Down Expand Up @@ -305,6 +303,7 @@ def test_LogFormatterExponent_blank():
def test_LogFormatterSciNotation():
test_cases = {
10: (
(-1, '${-10^{0}}$'),
(1e-05, '${10^{-5}}$'),
(1, '${10^{0}}$'),
(100000, '${10^{5}}$'),
Expand Down
7 changes: 4 additions & 3 deletions lib/matplotlib/ticker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,14 +898,15 @@ def __call__(self, x, pos=None):
if x == 0.0:
return '0'
sign = np.sign(x)
x = abs(x)
# only label the decades
fx = math.log(abs(x)) / math.log(b)
fx = math.log(x) / math.log(b)
isDecade = is_close_to_int(fx)
exponent = np.round(fx) if isDecade else np.floor(fx)
coeff = np.round(x / b ** exponent)
if coeff in self.sublabel:
if not isDecade and self.labelOnlyBase:
s = ''
return ''
elif x > 10000:
s = '%1.0e' % x
elif x < 1:
Expand Down Expand Up @@ -1032,7 +1033,7 @@ def __call__(self, x, pos=None):
fx = math.log(abs(x)) / math.log(b)
is_decade = is_close_to_int(fx)
exponent = np.round(fx) if is_decade else np.floor(fx)
coeff = np.round(x / b ** exponent)
coeff = np.round(abs(x) / b ** exponent)

sign_string = '-' if x < 0 else ''

Expand Down