Skip to content

Warn on invalid log axis limits, per issue #7299 #7367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 31, 2016
Merged

Warn on invalid log axis limits, per issue #7299 #7367

merged 3 commits into from
Oct 31, 2016

Conversation

cfackler
Copy link
Contributor

This change implements a warning when attempting to set invalid limits for a log-scale axis, per issue #7299.

Also fixed a minor typo in the set_xlim() docstring.

@cfackler
Warn on invalid log axis limits, per issue matplotlib#7299
bf0dfde 
An attempt to call set_xlim() or set_ylim() with non-positive limits
on a log-scale axis will produce a warning.
@cfackler
Fix typo in set_xlim() docstring
1f675ad
@NelleV
Copy link
Member

NelleV commented Oct 31, 2016

Thanks for the patch!
Can the error be more specific? (something like "provided values will be ignored")

@cfackler
Copy link
Contributor Author

Sure! I just pushed an updated warning message.

@NelleV NelleV changed the title Warn on invalid log axis limits, per issue #7299 [MRG+1] Warn on invalid log axis limits, per issue #7299 Oct 31, 2016
dopplershift
dopplershift approved these changes Oct 31, 2016
View reviewed changes
Copy link
Contributor

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@NelleV NelleV merged commit a30f451 into matplotlib:master Oct 31, 2016
@QuLogic QuLogic added this to the 2.1 (next point release) milestone Oct 31, 2016
@QuLogic QuLogic changed the title [MRG+1] Warn on invalid log axis limits, per issue #7299 Warn on invalid log axis limits, per issue #7299 Dec 7, 2016
@dstansby dstansby mentioned this pull request Jan 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@cfackler @NelleV @dopplershift @QuLogic