ENH: restore default ability to label some minor log ticks. #7419
Conversation
This partly restores the functionality that was added in PR matplotlib#5161 and partly removed in matplotlib#7000. The "partly" is because now the labeling of minor log ticks is turned on only when numdecs (the axis range in powers of the log base) is less than or equal to one, rather than 3. This also fixes a bug that was causing double labeling with a base of 2; minor ticks were coinciding with major ticks, and both were being labeled.
| subs = np.array([1.0]) | ||
| elif numdec > 6: | ||
| if self._subs is None: # autosub for minor ticks | ||
| if numdec > 10 or b < 3: |
There was a problem hiding this comment.
Maybe you should add a comment why no minor ticks should be label when b > 3.
| @@ -853,7 +853,7 @@ def set_locs(self, locs): | |||
| vmax = math.log(vmax) / math.log(b) | |||
| numdec = abs(vmax - vmin) | |||
|
|
|||
| if numdec > 3: | |||
| if numdec > 1: | |||
There was a problem hiding this comment.
My 2 cents is that we are trying to be too smart here and it has unintended consequences for anyone trying to use this formatter. At most, this sublabel filtering should be disabled by default (and possibly activated internally).
Also, the sublabel should probably (if kept) be private.
|
Overall, I think restoring the minor tick labels when one decode or less is displayed is a good idea. |
|
@NelleV, without sublabel filtering in some form, the sublabels will often be too crowded on any subplot, especially for the last few--7, 8, and 9. I think the filtering could be improved, though, so that the all ticks would be labeled when there are very few of them. With a log scale, very few labels are needed to orient the viewer, and excess labels rapidly become clutter even if they don't overlap--which they are prone to do. |
|
Note from Monday AM discussion: this can be merged, and then followed up with additional changes in #7414. A new kwarg is needed to control the subsetting of label formatting. |
|
@tacaswell Do you want to check this PR out? |
|
I understand @NelleV 's point about this being a bit too smart and typically would agree, however in this case I think this is the least-bad option. This is mostly a re-hash of the discussion last week, but typing this out for the record and to make sure I really agree with it ;) The locators decide where to put ticks and the formatters decide how to label them. For most linear axis situations, you label all major ticks an no minor ticks and the default auto-locator keeps there being a decent number of major ticks visible. For log we are further constrained that decadal ( A more general way to fix this would be to add a 👍 on merging this now and sorting out better ergonomics to control which ticks are labeled later. |
This partly restores the functionality that was added in
PR #5161 and partly removed in #7000. The "partly" is because
now the labeling of minor log ticks is turned on only when
numdecs (the axis range in powers of the log base) is less
than or equal to one, rather than 3.
This also fixes a bug that was causing double labeling with a
base of 2; minor ticks were coinciding with major ticks, and
both were being labeled.