BLD: look for an ghoauth token when using ghtools #7446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/minrk/ghpro is indeed in progress :-) I've seen the notification and can try to come back to it later. We've converging on an idea with @yuvipanda for streamlining github workflow. |
|
hum, why not store the token in keyring as well ? |
|
Because I am cranky and do not have any sort of keyring set up on any of my computers 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, you get rate-banned from the gh api pretty quickly if you try to update our PR/Issue summary pages.
I have been popping this off my stash/just rewriting everytime I need to do this.
These files are (I think) vendored from the IPython/Jupyter tools, might want to consider refreshing from it's upstream (or relying on the project @Carreau is working on to unify these across the scipy stack).
Nice to have this next time the docs get refreshed.