Skip to content

TST: Fixed test_log_margins test #7453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2016
Merged

TST: Fixed test_log_margins test #7453

merged 1 commit into from
Nov 13, 2016

Conversation

Kojoley
Copy link
Member

@Kojoley Kojoley commented Nov 13, 2016

Closes #7452

@Kojoley Kojoley added this to the 2.0.1 (next bug fix release) milestone Nov 13, 2016
dopplershift
dopplershift approved these changes Nov 13, 2016
View reviewed changes
Copy link
Contributor

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@efiring
Copy link
Member

efiring commented Nov 13, 2016

@Kojoley, peripheral note: the Travis failure was the pytest run, after 25 minutes; I've seen this failure more often than not. Is there anything that can be done about it?

@efiring efiring merged commit 8515322 into matplotlib:master Nov 13, 2016
efiring added a commit that referenced this pull request Nov 13, 2016
@efiring
Merge pull request #7453 from Kojoley/fix-test_log_margins
e6f2222 
TST: Fixed `test_log_margins` test
@efiring
Copy link
Member

efiring commented Nov 13, 2016

back-ported to v2.x as e6f2222

@Kojoley
Copy link
Member Author

Kojoley commented Nov 14, 2016 •
edited
Loading

@efiring I've seen this failure on both nose and pytest previously. Today I have run test_mixedsubplots about 500 times plus the whole test_mplot3d.py about 1500 times and it did not fail a single time. Unfortunately I do not have any idea what it could be and how to reproduce this failure. We have to grab a diff image from travis/appveyor at least to understand what is going on there,

@QuLogic QuLogic modified the milestones: 2.0.1 (next bug fix release), 2.0 (style change major release) Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Kojoley @efiring @dopplershift @QuLogic