Skip to content

Remove some numpy 1.6 workarounds #7494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 24, 2016
Merged

Remove some numpy 1.6 workarounds #7494

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
207edcf
Remove local definition of putmask
dstansby Nov 21, 2016
8ce11f2
Use minlength kwarg
dstansby Nov 21, 2016
79b9ee0
Simplifiy to_array for numpy >= 1.7
dstansby Nov 21, 2016
3a42131
Replace _putmask calls with copyto calls
dstansby Nov 21, 2016
77dbccc
Remove old to_array method
dstansby Nov 21, 2016
74d2d33
Simplify convert_to_string for numpy >= 1.7
dstansby Nov 21, 2016
fcef8fd
Use numpy's unicode type in covert_to_string
dstansby Nov 21, 2016
aa0e899
Fix convert_to_string method
dstansby Nov 21, 2016
13c965d
Remove convert_to_string method
dstansby Nov 21, 2016
2983fbd
Remove category string conversion test
dstansby Nov 21, 2016
430f789
Remove old numpy 1.6 comment
dstansby Nov 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove old to_array method
  • Loading branch information
@dstansby
dstansby committed Nov 21, 2016
commit 77dbcccf2a35ec4003ad29e0f25def8947b2fe72
8 changes: 2 additions & 6 deletions lib/matplotlib/category.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@
import matplotlib.ticker as ticker


def to_array(data, maxlen=100):
return np.array(data, dtype=np.unicode)


class StrCategoryConverter(units.ConversionInterface):
@staticmethod
def convert(value, unit, axis):
Expand All @@ -29,7 +25,7 @@ def convert(value, unit, axis):
if isinstance(value, six.string_types):
return vmap[value]

vals = to_array(value)
vals = np.array(value, dtype=np.unicode)
for lab, loc in vmap.items():
vals[vals == lab] = loc

Expand Down Expand Up @@ -105,7 +101,7 @@ def update(self, new_data):

def _set_seq_locs(self, data, value):
# magic to make it work under np1.6
strdata = to_array(data)
strdata = np.array(data, dtype=np.unicode)
# np.unique makes dateframes work
new_s = [d for d in np.unique(strdata) if d not in self.seq]
for ns in new_s:
Expand Down