Skip to content

Commit to fix a broken link #7496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 22, 2016
Merged

Commit to fix a broken link #7496

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f44c3c
Commit to fix a broken link
nalshihabi Nov 21, 2016
29f8e43
Small change based on request
nalshihabi Nov 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/matplotlib/dates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,8 +274,7 @@ def _from_ordinalf(x, tz=None):
class strpdate2num(object):
"""
Use this class to parse date strings to matplotlib datenums when
you know the date format string of the date you are parsing. See
:file:`examples/load_demo.py`.
you know the date format string of the date you are parsing.
Copy link
Member

@story645 story645 Nov 21, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the format string of the date being parsed is known. (May as well remove the second person...?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by remove the second person?

Copy link
Member

@story645 story645 Nov 21, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of you. Granted, this is a personal preference so I wouldn't hold up a merge over it. (Also edited language a bit more)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@story645 I think quoting the first sentence would have clarified things; at first I thought it was just a statement instead of a suggestion of how to write the sentence.

"""
def __init__(self, fmt):
""" fmt: any valid strptime format is supported """
Expand All @@ -292,7 +291,7 @@ class bytespdate2num(strpdate2num):
"""
Use this class to parse date strings to matplotlib datenums when
you know the date format string of the date you are parsing. See
:file:`examples/load_demo.py`.
:file:`examples/pylab_examples/load_converter.py`.
"""
def __init__(self, fmt, encoding='utf-8'):
"""
Expand Down