FIX: workaround py2 unicode issues #7509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9a8ed26 backported matplotlib#7436 which fixed a warning about non explicitly encoded non-ascii characters. This 'just works' on python3, but we need to explicitly make the string with the unicode (¶ for the links) as unicode for py2. We can not use `from __future__ import unicode_literals` due to issues with shpinx expecting bytes (str) not unicode.
4a947cf to
b467001
Compare
|
Failure is one of the transient tex / string IO related ones. Self-merging to un-break 2.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9a8ed26 backported #7436 which fixed a
warning about non explicitly encoded non-ascii characters.
This 'just works' on python3, but we need to explicitly make the string
with the unicode (¶ for the links) as unicode for py2.
We can not use
from __future__ import unicode_literalsdue to issueswith shpinx expecting bytes (str) not unicode.
This took way too long to track down, really looking forward to dropping python2.