Skip to content

Fix some minor warnings in extensions #7514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 27, 2016
Merged

Fix some minor warnings in extensions #7514

merged 7 commits into from
Nov 27, 2016

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Nov 25, 2016

Fix prototypes, an unused variable and some new misleading indentation warnings on GCC 6.

@QuLogic
Fix invalid C prototype.
612856a 
Might be the only case of -Wstrict-prototypes being used.
@QuLogic
BLD: Fix removal of -Wstrict-prototypes option.
d5b150b 
Current releases of distutils (2.7 & 3.5, at least) import
customize_compiler into the build_ext namespace, so changing the
original doesn't actually have any effect.
@QuLogic
Remove unused variable.
450f6f4
@QuLogic
Fix misleading indentation warnings in Agg code.
99f6357
@QuLogic QuLogic added the Build label Nov 25, 2016
@QuLogic QuLogic added this to the 2.1 (next point release) milestone Nov 25, 2016
@QuLogic
Copy link
Member Author

QuLogic commented Nov 26, 2016

Also fixed warnings about format specifiers and doubly-defined macros.

@QuLogic QuLogic modified the milestones: 2.0.1 (next bug fix release), 2.1 (next point release) Nov 26, 2016
@QuLogic
Fix NumPy's printf format specifiers in C++.
1ccdfc1 
Not sure why it works locally but not on Travis.
@QuLogic QuLogic changed the title Fix some minor warnings in extensions [MRG] Fix some minor warnings in extensions Nov 26, 2016
@NelleV NelleV changed the title [MRG] Fix some minor warnings in extensions [MRG+1] Fix some minor warnings in extensions Nov 26, 2016
@NelleV
Copy link
Member

NelleV commented Nov 26, 2016

I've approved this, but this is typically things that should not go into 2.x at this point.

@QuLogic
Copy link
Member Author

QuLogic commented Nov 26, 2016

Admittedly, it got a bit larger than I expected (I could have sworn that NPY_INTP_FMT thing was done already), but besides that, these are trivial warnings to fix. Trivial warnings are always useful to fix because you never know how a user might misinterpret them. But anyway, it's only a build time thing, so that's why it's milestoned 2.0.1, not 2.0.

@tacaswell
Copy link
Member

The unused variable came in via #5672 and was made redundant via #6764

@tacaswell
Copy link
Member

tacaswell commented Nov 27, 2016 •
edited
Loading

from https://stackoverflow.com/questions/8132399/how-to-printf-uint64-t it looks like it is a difference between compilers that requires __STDC_FORMAT_MACROS on travis but not locally (as I assume @QuLogic is using a 'modern' compiler and travis is running the ubuntu 12.04)

@tacaswell tacaswell merged commit 3972533 into matplotlib:v2.x Nov 27, 2016
@QuLogic QuLogic deleted the ext-warnings branch November 28, 2016 01:24
@QuLogic
Copy link
Member Author

QuLogic commented Nov 28, 2016

Ah yes, gcc 6.2.1; I always forget it's that much newer (especially as Travis becomes older and older.)

@QuLogic QuLogic changed the title [MRG+1] Fix some minor warnings in extensions Fix some minor warnings in extensions Nov 28, 2016
@QuLogic QuLogic modified the milestones: 2.0.1 (next bug fix release), 2.0 (style change major release) Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NelleV NelleV NelleV approved these changes

Assignees
No one assigned
Labels
Build
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @NelleV @tacaswell