Begin deprecation of "hold": remove from examples #7515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you want to create one whole big PR or should we review/merge as these come in. |
|
If you want to merge this, go ahead. I am working on stage 2 right now, but if this is merged I can easily make that another PR. Stage 2 is not so trivial, so it might require some revisions. |
|
This is actually independent of stage 2, so please go ahead and merge it whenever you like. I will make stage 2 a separate PR right now. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a start on addressing #3070. The first commit should be uncontroversial. I will look into adding the deprecation warning in subsequent commits.