Skip to content

double tolerance for test_png.py/pngsuite on Windows #7531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2016

Conversation

efiring
Copy link
Member

@efiring efiring commented Nov 29, 2016

This is whacking another random Windows mole in an attempt to get past Appveyor.

@NelleV
Copy link
Member

NelleV commented Nov 30, 2016

I'm closing and reopening. One of the appveyor tests did not seem to run properly.

@NelleV NelleV closed this Nov 30, 2016
@NelleV NelleV reopened this Nov 30, 2016
@NelleV
Copy link
Member

NelleV commented Nov 30, 2016

If I am not mistaken, this tackles #6620 and #6604

@efiring
Copy link
Member Author

efiring commented Nov 30, 2016

No connection to #6620, which is about segfaults on 32-bit systems, not minuscule image failures.
I don't think it is connected to #6604 either, because that is also about 32-bit system-specific image failures--fairly large ones.

So on Windows there seem to be intermittent non-deterministic behavior episodes causing failures sometimes, but not always or on all of the runs. That's what the present trivial PR addresses--one such example. I expect many more will crop up over time.

In addition, it seems there are some real problems with 32-bit systems behaving differently than 64-bit systems, which should not happen. That's much harder to deal with, and I suspect impossible for us to track down. The problem is likely buried deep in some library, maybe with a helping hand from a CPU bug.

@NelleV NelleV changed the title double tolerance for test_png.py/pngsuite on Windows [MRG+1] double tolerance for test_png.py/pngsuite on Windows Dec 1, 2016
@tacaswell tacaswell merged commit 3fad2d5 into matplotlib:master Dec 1, 2016
@QuLogic QuLogic changed the title [MRG+1] double tolerance for test_png.py/pngsuite on Windows double tolerance for test_png.py/pngsuite on Windows Dec 1, 2016
@QuLogic QuLogic added this to the 2.1 (next point release) milestone Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants